Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nmf #33

Closed
wants to merge 4 commits into from
Closed

Add nmf #33

wants to merge 4 commits into from

Conversation

xillig
Copy link
Collaborator

@xillig xillig commented Jul 18, 2024

added NMFTM, including theta and beta as a model attribute as requested

@AnFreTh
Copy link
Owner

AnFreTh commented Jul 18, 2024

from stream.models import NMFTM

from tests.model_validation import validate_model
validate_model(NMFTM, tfidf_args={"min_df": 1, "max_df": 0.5})

Returns:

AssertionError: The sum of 'theta' values along axis 1 must be all ones.

Should this not be the case for NMF?

Could you also add the logger infos for NMF similar to e.g. LDA or KmeansTM?

Copy link
Owner

@AnFreTh AnFreTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in NMFTM:

  • theta columns should sum to one
  • Add possibility to either fit with tf-idf or bow
  • Add logging info

minor:

  • delete print statements in KmeansTM.py
  • no .ipynb for every model in the examples

@AnFreTh
Copy link
Owner

AnFreTh commented Aug 16, 2024

added NMF with #87

@AnFreTh AnFreTh closed this Aug 16, 2024
@AnFreTh AnFreTh deleted the add_NMF branch August 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants