Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@o3r/schematics dynamic import should be static? #1429

Closed
vscaiceanu-1a opened this issue Feb 29, 2024 · 0 comments · Fixed by #1469
Closed

@o3r/schematics dynamic import should be static? #1429

vscaiceanu-1a opened this issue Feb 29, 2024 · 0 comments · Fixed by #1469

Comments

@vscaiceanu-1a
Copy link
Member

vscaiceanu-1a commented Feb 29, 2024 •
edited
Loading

Initially all imports for @o3r/schematics were dynamic. Now we are doing static imports in many places (some files have both static and dynamic import).

image

We may want to convert the dynamic imports into static ones in this case.

Originally posted by @vscaiceanu-1a in #1220 (comment)
@kpanot kpanot mentioned this issue Mar 8, 2024
Merged
@kpanot kpanot linked a pull request Mar 8, 2024 that will close this issue
feat: migrate schematics import to dynamic #1469
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 12, 2024
@kpanot
feat: migrate schematics import to dynamic (#1469)
0234135 
## Proposed change

Migrate schematics import to dynamic

## Related issues

- 🚀 Feature #1429

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate schematics import to dynamic AmadeusITGroup/otter
1 participant
@vscaiceanu-1a