Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable config support #68

Open
duncte123 opened this issue Dec 31, 2020 · 0 comments · May be fixed by #70
Open

Environment variable config support #68

duncte123 opened this issue Dec 31, 2020 · 0 comments · May be fixed by #70

Comments

@duncte123
Copy link
Contributor

I'm hosting my own instance of butler on a server. And since I'm planning to make that instance run with docker instead I thought that I might as well make the config accept env vars with a program flag.

The idea is that by running java -Dconfig_type=env -jar Bot.jar it will switch the way it loads any configurations and parse them from the env instead.
The env keys will most likely be prefixed with BUTLER_ (eg BUTLER_BOT_TOKEN=....).

I'm also going to make a wrapper class that can serialize and deserialize the JSON config when the config type is not set to env.

I made this issue to track any ideas and must-haves before starting.

@duncte123 duncte123 linked a pull request Feb 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant