Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use complete norm to compute common gradients in lstsq-grad method #130

Open
carterbox opened this issue Feb 26, 2021 · 0 comments
Open

Use complete norm to compute common gradients in lstsq-grad method #130

carterbox opened this issue Feb 26, 2021 · 0 comments
Labels
bug Something isn't working ptycho wontfix This will not be worked on

Comments

@carterbox
Copy link
Contributor

According to the manuscript, the least-squares grad common gradients denominator should be the norm across all batches not just the current batch. This is probably implemented incorrectly and needs to be fixed.
@carterbox carterbox added bug Something isn't working wontfix This will not be worked on labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ptycho wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carterbox