Search/Replace - Regex Issue Escaped Characters

[caseychambliss]

Acode Version: 1.8.1 (274)
OS: Android 13

When using the Search/Replace dialog the replace with escaped characters such as

• \n
• \r
• \t

the replacement is with these literal characters of:

• "\n" instead of a new line character
• "\r" instead of a return character
• "\t" instead of a tab character

The replace field does seem to work for other regular expressions such as back reference, so I believe the issue is only with escaped characters.

This was called out previously in another issue over a year ago, but resubmitting after re-explaining.

I would be happy to donate to this project if this can be addressed.

[caseychambliss]

I'm not a programmer, but looking at this file starting on line 145 may be where to start looking.

Acode/src/handlers/quickTools.js

case 'replace':
  editor.replace($replaceInput.value || '');
  break;

case 'replace-all':
  editor.replaceAll($replaceInput.value || '');
  break;

[caseychambliss]

I'm not a programmer, but looking at this file starting on line 145 may be where to start looking.

Acode/src/handlers/quickTools.js

case 'replace':
  editor.replace($replaceInput.value || '');
  break;

case 'replace-all':
  editor.replaceAll($replaceInput.value || '');
  break;

From what little I know and what I see here:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace

There may be a need to encapsulate the replacement text with the "/" character on the beginning and end of the text string when the Regular Expressions toggle is selected.

Also, the syntax of the replace arguments looks to be different than the documentation.

These are all guesses on my part.

[RaSan147]

It seems the find and replace is missing multiline functionality. Since search has an entire personal bar, i would be great to have multi line find and replace. We won't mind if thats moved to settings.
I'll try checking if there's any way i can implement that.

[RaSan147]

Acode Version: 1.8.1 (274) OS: Android 13

When using the Search/Replace dialog the replace with escaped characters such as

• \n
• \r
• \t

the replacement is with these literal characters of:

• "\n" instead of a new line character
• "\r" instead of a return character
• "\t" instead of a tab character

The replace field does seem to work for other regular expressions such as back reference, so I believe the issue is only with escaped characters.

This was called out previously in another issue over a year ago, but resubmitting after re-explaining.

I would be happy to donate to this project if this can be addressed.

Something to note, not even VS code parse \n to newline in replace, they keep it like it is what it is. (And there are reasons for it too) but a toggle or an multiline + \t + \r supported character find and replace bar is what we actually need.

[deadlyjack]

I'll see what can be done. Thanks for reporting.

[mpmcpherson]

To add my use case: I will often paste large tracts of text into a file I'm editing (for example, when I'm prototyping something and I want to pull in a reasonable dataset for testing -say, a couple hundred key-value pairs- without having to stand up a database and db connection) which I then need to sanitize and format.

In sublime text, I would use a regex to properly format the data, to replace certain newlines with commas or colons, etc. Not being able to do this sort of transformation is a real problem if I want to use this for quick and dirty proof of concept programming.

Are you already working on a feature branch for this? I'd be happy to contribute some of my time.

[deadlyjack]

Newer version of app as search in all files feature, which support multiline too. The feature is in beta version but you can try it. Read more https://github.com/deadlyjack/Acode/blob/main/CAHNGELOG.md

[mpmcpherson]

I see that there are two versions of this application in the app store. Is the other one the beta version? Am I going to have to pay for it again to remove ads from the beta?

[deadlyjack]

nope, join telegram group and download the app for free. new version is not available on play store yet.

…

On Sat, Jun 3, 2023, 7:04 AM Michael P McPherson ***@***.***> wrote: I see that there are two versions of this application in the app store. Is the other one the beta version? Am I going to have to pay for it again to remove ads from the beta? — Reply to this email directly, view it on GitHub <#679 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJHIHIZ5H2VALNBQJFAI2SLXJKIBTANCNFSM6AAAAAAWT7UUKE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[sekedus]

Tracking this in an existing issue #280