Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing Mocap Experiments and possible bug in code #1

Open
abdulfatir opened this issue Jun 14, 2022 · 1 comment
Open

Reproducing Mocap Experiments and possible bug in code #1

abdulfatir opened this issue Jun 14, 2022 · 1 comment

Comments

@abdulfatir
Copy link

Hi!

Thanks a lot for releasing a clean implementation of your model.

I am trying to reproduce the results reported in the paper for the Mocap dataset. Can I confirm that the default arguments in this file correspond to the best results reported in the paper (most of the things seem to match except the number of epochs)? If not, could you please share the best config?

There also appears to be a bug in the following line:

loss = recon_nll + encoder_kl*self.gamma + weight**model_kl + vae_init_loss

Should it be weight*model_kl instead of weight**model_kl?

I tried training the model both before and after fixing this potential bug and I got the following test MSE values:

weight**model_kl, decoder_dist: True, epochs: 1500 = 19.74 +/- 0.04
weight*model_kl, decoder_dist: True, epochs: 1500 = 17.32 +/- 0.03

@abdulfatir
Copy link
Author

Hi! Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant