Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/wrong password indication #233

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

HelloSniperMonkey
Copy link
Contributor

Description

This PR addresses an issue where entering a wrong password in the desktop view of the app does not display a visual indication of the error. This fix adds proper error handling and a clear visual indication to inform users when they have entered an incorrect password.

Relevant Motivation and Context

The lack of visual feedback for wrong password entries created confusion for users and a poor user experience. This fix ensures consistent and clear error messaging across all platforms.

Fixes #232

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally on desktop view to verify that the error indication appears correctly when an incorrect password is entered.
  • Verified responsiveness and consistent error display across screen sizes and browsers.
Screen.Recording.2025-01-17.at.12.22.20.AM.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@HelloSniperMonkey
Copy link
Contributor Author

can you please review ? @mdmohsin7

@HelloSniperMonkey
Copy link
Contributor Author

i found a amazing article for users who are facing problem problem running the project on macos because of many firebase or keychain errors

@HelloSniperMonkey HelloSniperMonkey force-pushed the fix/wrong_password_indication branch from 8491394 to 08246e9 Compare January 24, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entering wrong password in desktop view of app does not show a visual indication of wrong password
1 participant