You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if AMReX supported the functionality to name particle attributes (as strings). In WarpX, we added this as NamedParticleContainer, but as a mainstream implementation we could avoid deriving yet another class type (because if we do, we will again have additional compile-time to bind that custom type in pyAMReX), and instead could just extend the particle classes with these runtime details.
The text was updated successfully, but these errors were encountered:
AddRealComp(name, comm);
AddRealComp({name1, name2, ...}, {comm1, comm2, comm3}); // or as pairs?
so people can avoid double resizes (#3615#3861). (Same for Int.)
Deprecation
Please mark the old signature (w/o names) as deprecated - everyone can use the new signature without a problem: even if they do not use the name, this will make code more self-describing.
Currently, there are no systematic tests in AMReX CI that add (and remove #3595) runtime components to containers and then use these containers (e.g., copy from, redistribute, etc.). Such tests need to be added to ensure correctness and stability.
We currently do not cover the case where we add runtime components before the dummy multifab has been defined.
ax3l
changed the title
Named Particle Attributes
Named Particle SoA Attributes
Apr 1, 2024
ax3l
changed the title
Named Particle SoA Attributes
Named Particle SoA Components
Apr 1, 2024
X-ref:
ParticleContainer_*.to_df()
pyamrex#220It would be nice if AMReX supported the functionality to name particle attributes (as strings). In WarpX, we added this as
NamedParticleContainer
, but as a mainstream implementation we could avoid deriving yet another class type (because if we do, we will again have additional compile-time to bind that custom type in pyAMReX), and instead could just extend the particle classes with these runtime details.The text was updated successfully, but these errors were encountered: