Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for commands #5

Open
lightonflux opened this issue Apr 10, 2023 · 1 comment
Open

Suggestion for commands #5

lightonflux opened this issue Apr 10, 2023 · 1 comment

Comments

@lightonflux
Copy link

Nowadays, most Linux distros use systemd. And its tools have similar commands.

For example, instead of using brightness -g a user familiar with systemd tools might try get-brightness first. Or monitorctl brightness without any value, to get the value without changing it, similar to hostnamectl location.

I really like the shortcuts and would not suggest removing them. But personally, i think they can be improved. Both in terms of characters typed, and how natural the word order feels. For example, instead of b -i i suggest ib for "increase brightness". But of course this comes down to personal preference.

@5iddy
Copy link
Owner

5iddy commented Apr 10, 2023

I should include this in the help message but, the tool already support flags for subcommands.

so the following commands work.

monitorctl -bg
monitorctl -bi
monitorctl -bd

However, the reverse is not true. the following commands dont work.

monitorctl -ib
monitorctl -db
monitorctl -dg

I can try to make it so that the opposite order works as well.

Also, making monitorctl b and other equivalents to default to getting brightness seems like a good idea. Will work on it when I have time. But first, I need to handle support for laptops and make sure if something goes wrong the program doesn't panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants