Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol Specs] There is no straightforward details on how to use the SignatureValidatorManager with the protocol #55

Open
mmv08 opened this issue Oct 23, 2023 · 2 comments

Comments

@mmv08
Copy link
Member

mmv08 commented Oct 23, 2023

The specs briefly mention that the SignatureValidatorManager contract has to be enabled as a function handler in the protocol:

After a enabling a signature validator and setting SignatureValidatorManager as function handler in SafeProtocolManager

But in the detailed diagram above that section, this step is skipped

@rmeissner
Copy link
Member

rmeissner commented Oct 24, 2023

I would not separate these two components. They should be transparent to the user/ developers interacting with the protocol.

this is related to 5afe/safe-core-protocol#89

@rmeissner rmeissner changed the title There is no straightforward details on how to use the SignatureValidatorManager with the protocol [Protocol Specs] There is no straightforward details on how to use the SignatureValidatorManager with the protocol Oct 24, 2023
@mmv08
Copy link
Member Author

mmv08 commented Oct 24, 2023

They should be transparent to the user/ developers interacting with the protocol.

Does that mean that it should be defined in the protocol's implementation docs?

Does the manager need to be mentioned in the specs at all in such a case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants