Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-code-style check should not block PRs on pre-existing issues #36

Open
CodingCanuck opened this issue Apr 6, 2022 · 1 comment
Open

check-code-style check should not block PRs on pre-existing issues #36

CodingCanuck opened this issue Apr 6, 2022 · 1 comment

Comments

@CodingCanuck
Copy link
Contributor

3rdparty/stout#26 reports how pre-existing code format warnings block merging PRs that only touch unrelated files.

Can/should we change the check-code-style check to only complain about issues in files included in the PR to avoid unnecessary blocks?

I think it's totally valid to reject this suggestion, and instead we could declare that we should fix warnings at HEAD before submitting new work in order to keep head clean. (But if that's our stance, we should clean HEAD before turning on this check in any repos!)
@benh
Copy link
Member

benh commented Apr 6, 2022

@ArthurBandaryk wanted to take this on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benh @CodingCanuck