Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table component has issues with latest versions #2

Open
csrui opened this issue Apr 21, 2022 · 0 comments
Open

Table component has issues with latest versions #2

csrui opened this issue Apr 21, 2022 · 0 comments
Assignees
@csrui
Labels
bug Something isn't working

Comments

@csrui
Copy link
Contributor

csrui commented Apr 21, 2022

Running PHP8 and Livewire 2.10 breaks execution.

[21-Apr-2022 17:36:06 UTC] PHP Fatal error: An alias was defined for Livewire\WithPagination::getQueryString but this method does not exist in /backstate/src/Components/Livewire/Table/WithPagination.php on line 8
[21-Apr-2022 17:36:06 UTC] PHP Fatal error: An alias was defined for method getQueryString(), which exists in both TwentySixB\BackState\Components\Livewire\Table\WithPagination and TwentySixB\BackState\Components\Livewire\Table\WithFilteredSearch. Use TwentySixB\BackState\Components\Livewire\Table\WithPagination::getQueryString or TwentySixB\BackState\Components\Livewire\Table\WithFilteredSearch::getQueryString to resolve the ambiguity in /backstate/src/Components/Livewire/Table.php on line 12

It was possible to go around similar issues in PHP8 with Livewire 2.5.5 but there's no point. The Tables component needs refactoring.
@csrui csrui self-assigned this Apr 21, 2022
@csrui csrui added the bug Something isn't working label Apr 21, 2022
@csrui csrui pinned this issue Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csrui csrui

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csrui