Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO 2.0 #7

Open
downthecrop opened this issue Aug 2, 2023 · 3 comments
Open

TODO 2.0 #7

downthecrop opened this issue Aug 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@downthecrop
Copy link
Member

downthecrop commented Aug 2, 2023 •
edited
Loading

Is this request related to a bug?

2009Scape HD 2.0 Features and TODO

  • Audio. It's really close checkout this branch https://gitlab.com/downthecrop/rt4-client/-/tree/openalaudio?ref_type=heads
  • Rename a bunch of Pojav/Minecraft related things
  • Drag clicking
  • Capital "C" and "K" letters mistyping (General keyboard weirdness)
  • Progress Bar on HD loading (Would also disable the Logger output launching automatically once this is done)
  • There's some kind of memory leak? If you play HD for an hour it seems like the GC starts hitting every couple seconds isolated Pixel 6 issue. Probably Tensor chip issues. Xp drop plugin related

Describe the request.

No response

Anything else?

No response
@downthecrop downthecrop added the enhancement New feature or request label Aug 2, 2023
@downthecrop downthecrop changed the title TODO TODO 2.0 Aug 2, 2023
@downthecrop
Copy link
Member Author

Memeory leak info: I don't have a crash dump but HD crashes after about 10 minutes of any activity. Probably GLSurface android app stuff related and not the client itself. I'll investigate further when I do the renaming pass.

@downthecrop
Copy link
Member Author

Memeory leak info: I don't have a crash dump but HD crashes after about 10 minutes of any activity. Probably GLSurface android app stuff related and not the client itself. I'll investigate further when I do the renaming pass.

After some more testing it crashed after 17 minutes of HD on my Pixel 6 but didn't crash at all on the Device Simulator in Android Studio. I don't have other devices to test on. Profiler makes it seem like it's not a memory leak but something else like the thread getting killed.

@downthecrop
Copy link
Member Author

Memeory leak info: I don't have a crash dump but HD crashes after about 10 minutes of any activity. Probably GLSurface android app stuff related and not the client itself. I'll investigate further when I do the renaming pass.

After some more testing it crashed after 17 minutes of HD on my Pixel 6 but didn't crash at all on the Device Simulator in Android Studio. I don't have other devices to test on. Profiler makes it seem like it's not a memory leak but something else like the thread getting killed.

After a tipoff it seems that the problem of crashing is related (or can be replicated at least) via the xp drop plugin. Now disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@downthecrop