From e639efac96bb92e2da8489f20c3a488d3226bb71 Mon Sep 17 00:00:00 2001 From: Dark98 Date: Fri, 29 Oct 2021 04:38:04 +0100 Subject: [PATCH] Update CowKiller Premade Script Added More Inventory Checks To Stop The Script Being Weird Repackaged A Bit Updated Script Descriptions Lowered Waiting Time In Openlummybank Script --- .../ScriptFactorySDN/ScriptFactoryScript.java | 13 ++- .../Scripts/Combat/CowkillerBanking.java | 42 ++++++++++ .../ScriptFactorySDN/Scripts/Cowkiller.java | 81 ------------------- .../Scripts/Deps/Openlummybank.java | 27 +++++++ .../Scripts/Deps/Walktocows.java | 27 +++++++ .../ArdyCakesBanking.java} | 8 +- 6 files changed, 109 insertions(+), 89 deletions(-) create mode 100644 src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Combat/CowkillerBanking.java delete mode 100644 src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Cowkiller.java create mode 100644 src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Openlummybank.java create mode 100644 src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Walktocows.java rename src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/{ArdyCakes.java => Thieving/ArdyCakesBanking.java} (78%) diff --git a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/ScriptFactoryScript.java b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/ScriptFactoryScript.java index 1062a2c..b435b3e 100644 --- a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/ScriptFactoryScript.java +++ b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/ScriptFactoryScript.java @@ -1,8 +1,10 @@ package scriptfactory.AdvancedGui.ScriptFactorySDN; -import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Cowkiller; import org.parabot.core.desc.ScriptDescription; import org.parabot.environment.scripts.Category; +import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Combat.CowkillerBanking; +import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps.Openlummybank; +import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps.Walktocows; public class ScriptFactoryScript extends ScriptDescription { @@ -23,9 +25,12 @@ public ScriptFactoryScript(String scriptName, String author, String category, do public static ScriptFactoryScript[] getDescriptions() { return new ScriptFactoryScript[]{ - new Cowkiller(), - new Cowkiller.Walktocows(), - new Cowkiller.Openlummybank(), + //Scripts + new CowkillerBanking(), + //new ArdyCakes(), + //Deps + new Walktocows(), + new Openlummybank(), }; } diff --git a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Combat/CowkillerBanking.java b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Combat/CowkillerBanking.java new file mode 100644 index 0000000..a9ab8c4 --- /dev/null +++ b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Combat/CowkillerBanking.java @@ -0,0 +1,42 @@ +package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Combat; + +import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript; +import org.parabot.environment.scripts.Category; + +public class CowkillerBanking extends ScriptFactoryScript { + public CowkillerBanking() { + super( + "Cow killer (with banking)", + "Before", + Category.COMBAT, + 1.1, + "Kills Cows In Lumbridge And Banks In The Castle \n Set Tick Speed To 1000 For Best Results \n Can Be Started Anywhere", + "If Inventory-slots-used(28)\n" + + "Run-subscript(Openlummybank)\n" + + "Bank-all-except-IDs()\n" + + "Run-subscript(Walktocows)\n" + + "Endif\n" + + "IfNot In-Combat()\n" + + "If Entity-is-around(81,397,1767,1768)\n" + + "Take-Ground-item(2132)\n" + + "Take-Ground-item(526)\n" + + "Take-Ground-item(1739)\n" + + "If Inventory-slots-used(28)\n" + + "Run-subscript(Openlummybank)\n" + + "Bank-all-except-IDs()\n" + + "Run-subscript(Walktocows)\n" + + "Endif\n" + + "Interact-with-entity-by-ID(81,397,1767,1768,1)\n" + + "Endif\n" + + "IfNot Entity-is-around(81,397,1767,1768)\n" + + "If Inventory-slots-used(28)\n" + + "Run-subscript(Openlummybank)\n" + + "Bank-all-except-IDs()\n" + + "Endif\n" + + "Run-subscript(Walktocows)\n" + + "Endif\n" + + "Endif\n", + new String[]{"Walktocows", "Openlummybank"} + ); + } +} diff --git a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Cowkiller.java b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Cowkiller.java deleted file mode 100644 index 10006ea..0000000 --- a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Cowkiller.java +++ /dev/null @@ -1,81 +0,0 @@ -package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts; - -import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript; -import org.parabot.environment.scripts.Category; - -public class Cowkiller extends ScriptFactoryScript { - public Cowkiller() { - super( - "Cow killer (with banking)", - "Before", - Category.COMBAT, - 1.0, - "Kills cows in lumbridge and banks in the castle", - "If Inventory-slots-used(28)\n" + - "Run-subscript(Openlummybank)\n" + - "Bank-all-except-IDs()\n" + - "Run-subscript(Walktocows)\n" + - "Endif\n" + - "IfNot In-Combat()\n" + - "If Entity-is-around(81,397,1767,1768)\n" + - "Take-Ground-item(2132)\n" + - "Take-Ground-item(526)\n" + - "Take-Ground-item(1739)\n" + - "Interact-with-entity-by-ID(81,397,1767,1768,1)\n" + - "Endif\n" + - "IfNot Entity-is-around(81,397,1767,1768)\n" + - "Run-subscript(Walktocows)\n" + - "Endif\n" + - "Endif\n", - new String[]{"Walktocows", "Openlummybank"} - ); - } - - public static class Walktocows extends ScriptFactoryScript - { - public Walktocows() { - super( - "Walktocows", - "Before", - "Dependency", - 1.0, - "Walks to the cows in lumbridge from anywhere", - "IfNot Entity-is-around(81,397,1767,1768)\n" + - "Type(::stuck,1)\n" + - "Sleep(1500)\n" + - "Walk-to(3241,3226,14000)\n" + - "Walk-to(3259,3233,14000)\n" + - "Walk-to(3256,3250,14000)\n" + - "Walk-to(3252,3266,14000)\n" + - "Interact-with-entity-by-location(3253,3266,1)\n" + - "Walk-to(3258,3268,5000)\n" + - "Endif\n", - new String[]{} - ); - } - } - - public static class Openlummybank extends ScriptFactoryScript - { - public Openlummybank() { - super( - "Openlummybank", - "Before", - "Dependency", - 1.0, - "Opens the bank in lumbridge castle from anywhere", - "Type(::stuck,1)\n" + - "Sleep(1500)\n" + - "Interact-with-entity-by-location(3217,3218,1)\n" + - "Interact-with-entity-by-location(3215,3211,1)\n" + - "Interact-with-entity-by-location(3204,3207,1)\n" + - "Sleep(15000)\n" + - "Interact-with-entity-by-location(3204,3207,1)\n" + - "Interact-with-entity-by-location(3204,3207,2)\n" + - "Interact-with-entity-by-ID(494,3)\n" + - "Sleep(6000)\n", - new String[]{} - ); - } - } -} diff --git a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Openlummybank.java b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Openlummybank.java new file mode 100644 index 0000000..cd3a7e6 --- /dev/null +++ b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Openlummybank.java @@ -0,0 +1,27 @@ +package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps; + +import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript; + +public class Openlummybank extends ScriptFactoryScript +{ + public Openlummybank() { + super( + "Openlummybank", + "Before", + "Dependency", + 1.1, + "Opens the bank in lumbridge castle from anywhere", + "Type(::stuck,1)\n" + + "Sleep(1500)\n" + + "Interact-with-entity-by-location(3217,3218,1)\n" + + "Interact-with-entity-by-location(3215,3211,1)\n" + + "Interact-with-entity-by-location(3204,3207,1)\n" + + "Sleep(12000)\n" + + "Interact-with-entity-by-location(3204,3207,1)\n" + + "Interact-with-entity-by-location(3204,3207,2)\n" + + "Interact-with-entity-by-ID(494,3)\n" + + "Sleep(6000)\n", + new String[]{} + ); + } +} diff --git a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Walktocows.java b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Walktocows.java new file mode 100644 index 0000000..f20b9f5 --- /dev/null +++ b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Walktocows.java @@ -0,0 +1,27 @@ +package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps; + +import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript; + +public class Walktocows extends ScriptFactoryScript +{ + public Walktocows() { + super( + "Walktocows", + "Before", + "Dependency", + 1.0, + "Walks to the cows in lumbridge from anywhere", + "IfNot Entity-is-around(81,397,1767,1768)\n" + + "Type(::stuck,1)\n" + + "Sleep(1500)\n" + + "Walk-to(3241,3226,14000)\n" + + "Walk-to(3259,3233,14000)\n" + + "Walk-to(3256,3250,14000)\n" + + "Walk-to(3252,3266,14000)\n" + + "Interact-with-entity-by-location(3253,3266,1)\n" + + "Walk-to(3258,3268,5000)\n" + + "Endif\n", + new String[]{} + ); + } +} diff --git a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/ArdyCakes.java b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Thieving/ArdyCakesBanking.java similarity index 78% rename from src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/ArdyCakes.java rename to src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Thieving/ArdyCakesBanking.java index dbd5167..e244954 100644 --- a/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/ArdyCakes.java +++ b/src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Thieving/ArdyCakesBanking.java @@ -1,16 +1,16 @@ -package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts; +package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Thieving; import org.parabot.environment.scripts.Category; import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript; -public class ArdyCakes extends ScriptFactoryScript { - public ArdyCakes() { +public class ArdyCakesBanking extends ScriptFactoryScript { + public ArdyCakesBanking() { super( "ArdyCakes (with banking)", "Maui", Category.THIEVING, 1.0, - "Steals cakes in Ardy", + "Steals cakes in Ardy \n Start Next To Ardy Cake Stalls", "If Inventory-slots-used(28)\n" + "IfNot Entity-is-around(494)\n" + "Walk-to(2655,3286,35000)\n" +