From 30b9a30c6de25e3e0be735b0c50f5eb66a6e68ca Mon Sep 17 00:00:00 2001 From: Denis Date: Sun, 12 Jan 2025 21:58:57 +0200 Subject: [PATCH] Remove unnecessary checks --- contracts/extensions/AmountGetterWithFee.sol | 4 ---- 1 file changed, 4 deletions(-) diff --git a/contracts/extensions/AmountGetterWithFee.sol b/contracts/extensions/AmountGetterWithFee.sol index 584fbf18..4a53c73a 100644 --- a/contracts/extensions/AmountGetterWithFee.sol +++ b/contracts/extensions/AmountGetterWithFee.sol @@ -13,9 +13,7 @@ contract AmountGetterWithFee is AmountGetterBase { uint256 internal constant _BASE_1E5 = 1e5; uint256 internal constant _BASE_1E2 = 100; - error InvalidIntegratorFee(); error InvalidIntegratorShare(); - error InvalidResolverFee(); error InvalidWhitelistDiscountNumerator(); /** @@ -80,11 +78,9 @@ contract AmountGetterWithFee is AmountGetterBase { ) internal view returns (bool isWhitelisted, uint256 integratorFee, uint256 integratorShare, uint256 resolverFee, bytes calldata tail) { unchecked { integratorFee = uint256(uint16(bytes2(extraData))); - if (integratorFee > _BASE_1E5) revert InvalidIntegratorFee(); integratorShare = uint256(uint8(bytes1(extraData[2:]))); if (integratorShare > _BASE_1E2) revert InvalidIntegratorShare(); resolverFee = uint256(uint16(bytes2(extraData[3:]))); - if (resolverFee > _BASE_1E5) revert InvalidResolverFee(); uint256 whitelistDiscountNumerator = uint256(uint8(bytes1(extraData[5:]))); if (whitelistDiscountNumerator > _BASE_1E2) revert InvalidWhitelistDiscountNumerator(); (isWhitelisted, tail) = _isWhitelisted(extraData[6:], taker);