From 56fd4eee44a7d4b662f5c2a70e746be5856857c2 Mon Sep 17 00:00:00 2001 From: Moody Salem Date: Thu, 30 Jul 2020 18:30:04 -0500 Subject: [PATCH] fix(minVersionBump): swapped minor/major --- package.json | 2 +- src/minVersionBump.ts | 4 ++-- test/minVersionBump.test.ts | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 5d5430fb..089b1af6 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@uniswap/token-lists", "author": "Moody Salem", - "version": "1.0.0-beta.10", + "version": "1.0.0-beta.11", "license": "MIT", "main": "dist/index.js", "typings": "dist/index.d.ts", diff --git a/src/minVersionBump.ts b/src/minVersionBump.ts index a460e0c7..ab29b213 100644 --- a/src/minVersionBump.ts +++ b/src/minVersionBump.ts @@ -12,8 +12,8 @@ export function minVersionBump( updatedList: TokenInfo[] ): VersionUpgrade { const diff = diffTokenLists(baseList, updatedList); - if (diff.added.length > 0) return VersionUpgrade.MAJOR; - if (diff.removed.length > 0) return VersionUpgrade.MINOR; + if (diff.removed.length > 0) return VersionUpgrade.MAJOR; + if (diff.added.length > 0) return VersionUpgrade.MINOR; if (Object.keys(diff.changed).length > 0) return VersionUpgrade.PATCH; return VersionUpgrade.NONE; } diff --git a/test/minVersionBump.test.ts b/test/minVersionBump.test.ts index c113d763..d9344723 100644 --- a/test/minVersionBump.test.ts +++ b/test/minVersionBump.test.ts @@ -40,11 +40,11 @@ describe('#minVersionBump', () => { VersionUpgrade.PATCH ); }); - it('minor for remove only', () => { - expect(minVersionBump([tokenA], [])).toBe(VersionUpgrade.MINOR); + it('major for remove', () => { + expect(minVersionBump([tokenA], [])).toBe(VersionUpgrade.MAJOR); }); - it('major for add', () => { - expect(minVersionBump([], [tokenA])).toBe(VersionUpgrade.MAJOR); + it('minor for add', () => { + expect(minVersionBump([], [tokenA])).toBe(VersionUpgrade.MINOR); }); it('major for add/remove', () => { expect(minVersionBump([tokenB], [tokenA])).toBe(VersionUpgrade.MAJOR);