Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect options should warn us about chainIds formated as strings #18

Open
sembrestels opened this issue Jul 28, 2021 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@sembrestels
Copy link
Member

Right now Connect only accepts:

<Connect
    location={orgAddress}
    connector="thegraph"
    options={{network: "xdai"}}
>

and:

<Connect
    location={orgAddress}
    connector="thegraph"
    options={{network: 100}}
>

but it doesn't work when:

<Connect
    location={orgAddress}
    connector="thegraph"
    options={{network: "100"}}
>

It should warn when a number is passed as a string, because otherwise it is not clear for the dev why the DAO is not loading.

@0xGabi 0xGabi added the enhancement New feature or request label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants